Fix USB PID for arduino_nano_esp32s3 #8634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The USB PID for
arduino_nano_esp32s3was 0x0070. This is the PID Arduino uses for DFU. This caused the serial port not to show up on Windows if the Arduino ESP32 BSP was installed into Arduino and the corresponding Windows drivers to be installed. They took precedence over treating this as a normal serial port.MicroPython uses 0x056B. We have use that correct PID for
arduino_nano_esp32s3_inverted_status_led. Workaround is to use that build for now. The original PR flipped back and forth a bit.Tested by user Akihiro in discord, who encountered the original problem:
https://discord.com/channels/327254708534116352/1175489681048219729