Skip to content

add minimum validation for tilegrid size in terminalio.Terminal #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

FoamyGuy
Copy link
Collaborator

Attempts to resolve #7885

This PR adds minimum size validation that enforces the TileGrid being no smaller than 2x2, which is arguably still too small to be practically useful. Perhaps a higher limit would be appropriate?

If there is a desire to allow 1xN sized TileGrids the logic in this will have to get reworked.

Also something for consideration would be adding an example to the docs of terminalio module that illustrate how to use it. As noted in the issue there isn't currently any sample code for it anywhere that I'm aware of.

@FoamyGuy
Copy link
Collaborator Author

I'm not sure what happened in the failed actions build. It seems to have failed on something related to submodules, but I'm not sure what specific action it was taking at the time. I did test a build of openbook_m4 locally and was able to get successful build though.

@dhalbert
Copy link
Collaborator

I'm not sure what happened in the failed actions build. It seems to have failed on something related to submodules, but I'm not sure what specific action it was taking at the time. I did test a build of openbook_m4 locally and was able to get successful build though.

This looks like a transient CI failure. I will start a re-run of just the failed job.

@tannewt
Copy link
Member

tannewt commented Apr 24, 2023

This looks good to me. The main purpose is to prevent misunderstandings of what terminal needs.

@dhalbert dhalbert merged commit aae1b1d into adafruit:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using plain terminalio with displayio - ValueError: Tile index out of bounds
3 participants