Skip to content

Fix CIRCUITPY_PORT_SERIAL guard in serial_early_init. #10043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fix CIRCUITPY_PORT_SERIAL guard in serial_early_init. #10043

merged 1 commit into from
Feb 8, 2025

Conversation

eightycc
Copy link
Collaborator

@eightycc eightycc commented Feb 8, 2025

The CIRCUITPY_PORT_SERIAL guard in serial_early_init() excluded too much causing a hangup for RP2 port builds with DEBUG=1 and CIRCUITPY_CONSOLE_UART defined.

dhalbert
dhalbert approved these changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit e19ff43 into adafruit:main Feb 8, 2025
599 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eightycc @dhalbert