Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require specific ruff version #10035

Merged
merged 1 commit into from
Feb 7, 2025
Merged

require specific ruff version #10035

merged 1 commit into from
Feb 7, 2025

Conversation

jepler
Copy link
Member

@jepler jepler commented Feb 7, 2025

I was having trouble with pre-commit always finding files to change, because the ruff run during two different steps of pre-commit were different.

Installing the requirements with pip install -r requirements-dev.txt didn't resolve the problem, because the ruff version was not pinned. So, pin it now.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense , since pre-commit-config.yaml requires explicit versions.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I may have run into this too.

@tannewt tannewt merged commit a92e64c into adafruit:main Feb 7, 2025
600 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants