Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stop kwarg from busio.I2C().writeto #2082

Closed
tannewt opened this issue Aug 21, 2019 · 4 comments · Fixed by #3195
Closed

Remove stop kwarg from busio.I2C().writeto #2082

tannewt opened this issue Aug 21, 2019 · 4 comments · Fixed by #3195
Labels
breaks api circuitpython api
Milestone
6.0.0

Comments

@tannewt
Copy link
Member

tannewt commented Aug 21, 2019

With the introduction of writeto_then_readfrom into busio.I2C in 5.x. The stop kwarg is no longer needed. In fact, using it is likely the wrong thing to do since it is unsupported with Blinka.
@tannewt tannewt added this to the Long term milestone Aug 21, 2019
tannewt added a commit to tannewt/Adafruit_CircuitPython_Register that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
d979055 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
@tannewt tannewt modified the milestones: Long term, 6.0.0 Aug 21, 2019
tannewt added a commit to tannewt/Adafruit_CircuitPython_BoardTest that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
e76d860 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_VL6180X that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
0c11b3d 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_VEML6075 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
2f12d39 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_BusDevice that referenced this issue Aug 21, 2019
@tannewt
Change stop to False and throw error if True.
401037a 
It will be removed from libraries and then from here.
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_VCNL4010 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
e86cd37 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_TSL2591 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
7f1a072 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_TSL2561 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
3024de9 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_TMP007 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
1b8f5dc 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_TMP006 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
917fedf 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_TCS34725 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
b836f50 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_SI7021 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
b353e60 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_SI4713 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
f739bc9 
See adafruit/circuitpython#2082 for details.
tannewt added a commit to tannewt/Adafruit_CircuitPython_DS1307 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
fb96e0a 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_DRV2605 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
23e064a 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_CCS811 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
cb29ed9 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_CAP1188 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
5ec51d1 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_BNO055 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
84d2d38 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_APDS9960 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
a4315e2 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_AMG88xx that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
a18dde1 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_ADT7410 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
78425fc 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
tannewt added a commit to tannewt/Adafruit_CircuitPython_ADS1x15 that referenced this issue Aug 21, 2019
@tannewt
Remove stop kwarg and use write_then_readinto.
520e4f0 
See adafruit/circuitpython#2082 for details.
@tannewt tannewt mentioned this issue Aug 21, 2019
Merged
@kattni
Copy link

kattni commented Aug 22, 2019

We're looking for any assistance in testing all of the outstanding library PRs associated with this issue!

If you have any of these sensors and would like to help out, please grab something like a Feather M4 Express and do the following:

  1. Update to the latest Adafruit CircuitPython BusDevice release (4.0.0, released 22 August 2019)
  2. Find the PR for the sensor you'd like to test.
  3. Comment on the PR that you are going to test the PR. (This will avoid any duplicate work!)
  4. Test the code from the PR.
  5. If tested successfully, approve and merge the PR. If you do not have access to merge, please comment on the PR that you have tested it successfully and tag me (@kattni) in the approval comment.
  6. Do a new release on the library. (Again, if you do not have access, please comment on the PR and tag me (@kattni) in the comment.

If you have any questions, please tag me in a comment or find me on Discord in the #circuitpython channel.

Thanks!

dhalbert pushed a commit that referenced this issue Aug 28, 2019
@tannewt
Add writeto_then_readfrom to I2C API. Deprecate stop kwarg.
82d436d 
writeto_then_readfrom has been added to do a write -> no stop ->
repeated start -> read sequence. This is done to match the
capabilities of Blinka on Linux.

Code that uses stop=False will not work correctly on Blinka.
To fix, if stop=False then use writeto_then_readfrom otherwise use
writeto then readfrom_into.

First step in #2082
@kattni
Copy link

kattni commented Aug 28, 2019

All library PRs have been merged. Changes were tested with LIDARLite to verify changes work successfully.

@tampe125
Copy link

tampe125 commented Aug 29, 2019 •
edited
Loading

Hello, this change send to have broken some stuff. More info here adafruit/Adafruit_CircuitPython_VL6180X#7

@kattni

@tannewt tannewt mentioned this issue Jul 23, 2020
Merged
tannewt added a commit that referenced this issue Jul 23, 2020
@tannewt
Remove stop kwarg from I2C writeto.
4b6e029 
Fixes #2082
@kevinjwalters
Copy link

This has broken:

@kevinjwalters kevinjwalters mentioned this issue Dec 9, 2020
Closed
epid added a commit to epid/AloriumTech_CircuitPython_EvoM51 that referenced this issue Oct 22, 2021
@epid
Updated for newer versions of CircuitPython
297c7e4 
The stop kwarg was removed a couple of years ago. See here: adafruit/circuitpython#2082
@epid epid mentioned this issue Oct 22, 2021
Open
@fivesixzero fivesixzero mentioned this issue Nov 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks api circuitpython api
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Remove stop kwarg from I2C writeto. tannewt/circuitpython
4 participants
@tannewt @tampe125 @kevinjwalters @kattni