Account for fractions of a pixel when drawing #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
Previously, the endpoint of the line was always moved along in increments of 1 pixel, so that the endpoint would always be rounded down. This could accumulate to give quite large differences from what the program intended. Ensure that "goto" always ends up storing the floating point endpoints and that the line is drawn from the rounded-integer starting coordinate and rounded-integer ending coordinate. This makes the 3 test lines in the OP's "turtle_truncate.txt" example be the same length. Closes: #41
FoamyGuy
approved these changes
Dec 5, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 6, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_24LC32 to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_24LC32#25 from FoamyGuy/dont_rewrite_same Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.6.13 from 3.6.12: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#40 from jposada202020/adding_displayIO_example Updating https://github.com/adafruit/Adafruit_CircuitPython_VS1053 to 1.2.20 from 1.2.19: > Merge pull request adafruit/Adafruit_CircuitPython_VS1053#21 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.11.1 from 1.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#53 from FoamyGuy/debounced_example > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#52 from FoamyGuy/focal_touch_support > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#51 from FoamyGuy/use_ruff > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#49 from ch4nsuk3/expose-name-property > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#48 from ch4nsuk3/add-annotations > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#50 from FoamyGuy/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.1 from 3.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#45 from adafruit/issue41 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the endpoint of the line was always moved along in increments of 1 pixel, so that the endpoint would always be rounded down. This could accumulate to give quite large differences from what the program intended.
Ensure that "goto" always ends up storing the floating point endpoints and that the line is drawn from the rounded-integer starting coordinate and rounded-integer ending coordinate.
This makes the 3 test lines in the OP's "turtle_truncate.txt" example be the same length. (the second line in each pair in the photo shows the length of the line produced BEFORE the bugfix)
Closes: #41