add support for different chip detection + quad rotary demo #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ladyada thanks! i ran pylint for the example but i wanted to check on an error in seesaw.py in the i wasn't sure if the variable was maybe supposed to be |
caternuson
requested changes
Jun 27, 2023
|
@BlitzCityDIY ok i think if ixed that error, only the samd09 has weird offsets. now we just use the native pin names |
caternuson
requested changes
Jun 28, 2023
adafruit_seesaw/seesaw.py
Outdated
| if self.chip_id == _ATTINY8X7_HW_ID_CODE: | ||
| offset = pin | ||
| elif self.chip_id == _SAMD09_HW_ID_CODE: | ||
| self.chip_id == _SAMD09_HW_ID_CODE: |
There was a problem hiding this comment.
Simple syntax error here - missing if.
I think that's rippling out and causing a lot of the other failures. Might also need some black/pylint-ification of the two files as well.
There was a problem hiding this comment.
sigh sorry i thought it pushed, commited & pushed now
|
@ladyada OK, now it's just black (like clangformat, just run it and let it do what it wants) and pylint (fix or shush, etc). |
|
@BlitzCityDIY can you do the 🧹 - im getting roped into show stuff :) |
caternuson
approved these changes
Jun 28, 2023
|
thanks all :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 18, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.4.9 from 1.4.8: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#26 from adafruit/ladyada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.2.15 from 1.2.14: > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#17 from kbsriram/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#31 from adafruit/stemma_i2c Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.12.0 from 3.11.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#114 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.14.0 from 1.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#118 from ladyada/main Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.23 from 0.5.22: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#44 from furbrain/main > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#42 from tekktrik/dev/fix-build-bundle Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.1.0 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#59 from FoamyGuy/ethernet_example > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#58 from michalpokusa/server-headers Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.10 from 3.0.9: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#30 from joshua-beck-0908/timezone_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.9 from 1.14.8: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#92 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BlitzCityDIY will need linting n stuffs but is tested on a feather m4