adding type annotations #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Dec 3, 2024
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 5, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#27 from FoamyGuy/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL115A2 to 1.1.18 from 1.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#15 from FoamyGuy/use_ruff > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#14 from FoamyGuy/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.10 from 4.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#98 from michalpokusa/video-streaming-example Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 2.1.4 from 2.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#30 from FoamyGuy/use_ruff > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#29 from FoamyGuy/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.0 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#42 from FoamyGuy/standard_color_docs > Merge pull request adafruit/Adafruit_CircuitPython_turtle#43 from FoamyGuy/mode_default Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #20
pylint failed for the argument named
e, I'm not certain why since I didn't rename it or change the pylint version and it presumably succeeded sometime in the past. I wasn't sure what if anything theewas short for so I renamed the argument toother_polynomialwhich seems to describe what it is if my understanding of the code is accurate. I can put it back and use a lint ignore, or change it to something else is there is a different name that would be more appropriate.