Improve Ref Docs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Mar 6, 2018
adafruit_vcnl4010.py
Outdated
| @@ -168,7 +184,7 @@ def frequency(self, val): | |||
| # pylint: disable=inconsistent-return-statements | |||
| @property | |||
| def proximity(self): | |||
| """Get the detected proximity of an object in front of the sensor. This | |||
| """Returns the detected proximity of an object in front of the sensor. This | |||
There was a problem hiding this comment.
"The detected ..." Remove "Returns".
adafruit_vcnl4010.py
Outdated
| @@ -189,7 +205,7 @@ def proximity(self): | |||
|
|
|||
| @property | |||
| def ambient(self): | |||
| """Get the detected ambient light in front of the sensor. This is | |||
| """Returns the detected ambient light in front of the sensor. This is | |||
adafruit_vcnl4010.py
Outdated
| @@ -208,7 +224,7 @@ def ambient(self): | |||
|
|
|||
| @property | |||
| def ambient_lux(self): | |||
| """Get the detected ambient light in front of the sensor as a value in | |||
| """Returns the detected ambient light in front of the sensor as a value in | |||
kattni
approved these changes
Mar 9, 2018
|
Looks great, thanks! |
|
Guide updated. |
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 9, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#3 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#3 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#2 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_Trellis to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#8 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#7 from sommersoft/val_checks > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#5 from sommersoft/bytearray_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.1.1 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#16 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#15 from caternuson/master > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#14 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#13 from caternuson/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#4 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 3.1.0 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#4 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.9.0 from 0.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_WS2801 to 0.9.0 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_WS2801#2 from kattni/pypi > updated CoC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Issue #566
The following Learn Guide will need the 1 GitHub example code link updated:
https://learn.adafruit.com/using-vcnl4010-proximity-sensor?view=all#circuitpython-code