-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete code (Fixes #20) #23
Conversation
I saw that this Issue was flagged as a Good First Issue that nobody had tackled yet and thought I would try to help out. Please don't hold back on suggestions or best practices, I am trying to learn! |
looks good! i dont think we need the |
Thanks @ladyada, and sorry if I am missing something but if you look at all the code in this module, the other methods in this class (e.g., |
imma defer to @tannewt on stylistic decision on whether to return. i feel like the original code did not return so replacement shouldnt? |
I am happy to defer to whatever you and @tannewt feel is correct. Just let me know and I will make the changes and push to the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! The return is ok by me because it is consistent with the other implementations and future proofs us if the called method return something in the future. Note that all Python functions return a value, when a return statement is omitted the function returns None. So this will likely just return the None from the underlying function call.
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.3.1 from 3.3.0: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_BME680#40 from caternuson/iss39 > Merge pull request adafruit/Adafruit_CircuitPython_BME680#36 from adafruit/REUSE > Merge pull request adafruit/Adafruit_CircuitPython_BME680#38 from caternuson/iss37_spi_example > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.2.7 from 2.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#37 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.2 from 2.1.1: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_FONA#12 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_HTS221 to 1.1.3 from 1.1.2: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_HTS221#6 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_MSA301 to 1.2.5 from 1.2.4: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_MSA301#14 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.0.2 from 6.0.1: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#103 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_RockBlock to 1.3.1 from 1.3.0: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_RockBlock#19 from adafruit/REUSE Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#9 from caternuson/iss2_mcp2221 Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.2.1 from 1.2.0: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#9 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.4.3 from 1.4.2: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#21 from wildestpixel/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.3.4 from 0.3.3: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#23 from SAK917/adafruit/Adafruit_CircuitPython_TCA9548A#20-remove-obsolete-code Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 2.0.5 from 2.0.4: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#16 from adafruit/REUSE > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.3.3 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#25 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_Bitmap_Font to 1.3.4 from 1.3.3: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_Bitmap_Font#37 from jfurcean/fix_api_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_MIDI to 1.0.3 from 1.0.2: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_BLE_MIDI#6 from adafruit/REUSE Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 1.12.3 from 2.12.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#117 from kmatch98/bitmap_label_scale > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#116 from lesamouraipourpre/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Hue to 1.1.3 from 1.1.2: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_Hue#14 from adafruit/REUSE Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.13.2 from 0.13.1: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#43 from adafruit/REUSE > Hardcoded Black and REUSE versions > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_LIFX to 1.9.4 from 1.1.2: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_LIFX#10 from adafruit/REUSE Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.6.0 from 1.5.4: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#54 from makermelissa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.9.6 from 1.9.5: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_Requests#68 from jfabernathy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 3.0.1 from 3.0.0: > Hardcoded Black and REUSE versions > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#60 from adafruit/REUSE
Address change requested in Issue #20 by making the following changes:
Refactor
writeto_then_readfrom()
to be consistent with the other methods in the classby now returning
self_tca_i2c.writeto_then_readfrom()
Remove obsolete code in
writeto_then_readfrom()
as per @jepler in Issue #20I did test the changes to the extent I could (i.e., no errors at runtime and able to instantiate an adafruit_tca9548a.TCA9548A object in code), but I do not have a TCA9548A board to physically test.