Add max_attempts to get_local_time #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has failing actions due to some code formatting things. The easiest way to resolves the actions issues is to setup |
FoamyGuy
approved these changes
Jul 21, 2024
There was a problem hiding this comment.
This change looks good to me. I tested it successfully on a Pyportal Titano.
I added the max_attempts arg to the get_local_time() function on the base class too which just passes it thru to the function of the same name on the network class.
Thanks for adding this functionality @colonwq
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 22, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 7.1.4 from 7.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#169 from Jahor/fix_dhcp_expiration Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#103 from colonwq/update_get_local_time > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#101 from justmobilize/fix-readme-requirements Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_local_time() calls get_strftime() which calls connect().
connect() defaults to max_attempts=10 to connect to the wifi.
This patch allows the user to pass max_attempts to get_localtime() which will be passed to get_strftime() and used by connect().
Not setting the max_attempts value in get_local_time() uses the default max_attempts=10.
Not setting the max_attempts value in get_strftime() uses the default max_attempts=10