Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mcp9808_average temp+mqtt #34

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Conversation

Taxelas
Copy link
Contributor

@Taxelas Taxelas commented Feb 6, 2022

My python script to read mcp9808 temperature and publish it in mqtt.
Using discovery topic to create entity in Home Assistant

My python script to read mcp9808 temperature and publish it in mqtt.
Using discovery topic to create entity in Home Assistant
@tekktrik
Copy link
Member

Hey @Taxelas! Looks like this is failing the CI, you should be able to fix it using pre-commit! After you do that and push the changes, it should pass. You can find instructions on getting it set up here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a new commit with a few adjustments:

  • rename the file to be a python file and remove spaces from the name.
  • Change the copyright name to contributing user
  • re-arrange imports to satisfy pylint

The new example looks good to me after these changes. I don't have the hardware or custom mqtt infrastructure needed to test but this appears okay as far as I can tell.

examples/mcp9808_average temp+mqtt Outdated Show resolved Hide resolved
@FoamyGuy FoamyGuy merged commit 8c4c1a9 into adafruit:main Mar 7, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 8, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#15 from adafruit/require-busdevice
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.11 from 3.3.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#34 from Taxelas/patch-1
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoTre to 1.1.8 from 1.1.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoTre#16 from Neradoc/add-multitrellis-to-docs
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_Debouncer to 1.6.0 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Debouncer#37 from adafruit/manual_valueset

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_VL53L4CD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants