Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bad-whitespace pylint directive #61

Merged
merged 3 commits into from
Aug 26, 2020
Merged

remove bad-whitespace pylint directive #61

merged 3 commits into from
Aug 26, 2020

Conversation

jepler
Copy link
Member

@jepler jepler commented Aug 23, 2020

This directive has been removed from pylint 2.6.0.

dhalbert
dhalbert previously approved these changes Aug 23, 2020
View reviewed changes
@dhalbert dhalbert dismissed their stale review August 23, 2020 17:19

failed checks

@dhalbert dhalbert requested a review from a team August 23, 2020 17:20
@jepler
Copy link
Member Author

jepler commented Aug 23, 2020

Fails due to a pylint diagnostic that is unrelated and that I do not reproduce locally with pylint 2.6.0:

examples/lis3dh_spinner.py:19:0: C0411: third party import "import neopixel" should be placed before "import adafruit_lis3dh" (wrong-import-order)

@dhalbert
Copy link
Contributor

Fails due to a pylint diagnostic that is unrelated and that I do not reproduce locally with pylint 2.6.0:

Do you have Adafruit_blinka and related libraries installed locally? That's how I have matched these with the CI results.

@kattni
Copy link
Contributor

kattni commented Aug 24, 2020

@jepler Please update the import order, but be prepared for it to cascade fail on further imports one at a time. As Dan said, your environment probably isn't exactly the same as remote. I've had it happen like this.

@FoamyGuy FoamyGuy merged commit 72b82cb into adafruit:master Aug 26, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 26, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b17b8fd)
4b1c02a 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#59 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL34x to 1.11.4 from 1.11.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADXL34x#25 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#29 from jepler/pylint-fixes
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#28 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.2 from 2.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#27 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_BD3491FS to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BD3491FS#6 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitSPI to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitSPI#18 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#9 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#18 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#49 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#7 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#24 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#19 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3231 to 2.4.1 from 2.4.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3231#29 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_DS3502 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS3502#6 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#16 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#19 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#10 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.5 from 3.4.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA219#25 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_INA260#12 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.1.5 from 2.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS2MDL#10 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.3 from 5.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#61 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS35HW to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS35HW#6 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#9 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#9 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS0 to 2.2.3 from 2.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS0#20 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#23 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31855 to 3.2.4 from 3.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31855#20 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.4 from 2.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#21 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX9744 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX9744#13 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MMA8451 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MMA8451#14 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL115A2 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL115A2#9 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPL3115A2 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPL3115A2#15 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#26 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#13 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#10 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#20 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCT2075 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCT2075#14 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_PN532 to 2.2.1 from 2.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PN532#38 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.0.4 from 2.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#49 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP30 to 2.3.1 from 2.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP30#30 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#16 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI5351 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI5351#16 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1305 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1305#11 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.8.3 from 2.8.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#48 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#32 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_Thermal_Printer to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Thermal_Printer#19 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP006 to 2.1.3 from 2.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#12 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_Trellis to 1.3.4 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#16 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#33 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#18 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 4.1.3 from 4.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#15 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.10.3 from 0.10.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#13 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.3 from 3.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#17 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6075 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VEML6075#13 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.3.3 from 3.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#23 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#15 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_VS1053 to 1.2.3 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_VS1053#13 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.4 from 0.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#22 from jepler/remove-bad-whitespace-directive

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.5.3 from 1.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#31 from kattni/i2c-update

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#16 from FoamyGuy/public_width_and_height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@dhalbert dhalbert dhalbert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jepler @dhalbert @kattni @FoamyGuy