Add error checking and retries to the read and write functions #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am having issues with read errors on
Adafruit CircuitPython 9.2.1 on 2024-11-20; Adafruit Feather ESP32S3 4MB Flash 2MB PSRAM with ESP32S3
See here for more details.
I added try/except and retry to the
_read_word
and_write_word
functions. I also added a check to thecell_voltage
,cell_percent
, andcell_temperature
functions that will catch an error in a read during those functions and returnnone
if the read fails. It will be up to the user to decide what they want to do when that happens, but it won't crash user code. (probably)My experiences with these errors:
cell_voltage
function.)Possible Improvements: