Implement filters for indexed PNG #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested (and fixed)
|
FoamyGuy
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Looks good to me. Thank you @Neradoc! 🎉
I tested both sample images from the issue with this fix and the pink one does render properly now.
I also found an indexed image which makes use of all the scanline filter types and it renders properly as well. I also tested a few of the images from http://www.schaik.com/pngsuite/ successfully. All testing was on a Metro RP2350 with LCD shield.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 22, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 9.0.0 from 8.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#216 from justmobilize/wifi-manager-update Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.24.0 from 1.23.9: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#98 from Neradoc/add-filters-indexed-png Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Display_Emoji_Text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #97
Tested with he same heart PNGs.
Could not test the
paeth(filter 4) implementation.The middle one is with the non-fixed version.
Also updating
__version__.