Use ruff. add optional different format types to png example #85
Conversation
|
I am investigating the actions failure. it appears that mpy-cross has taken issue with something. |
|
Okay, the root of that issue was that currently used version of mpy-cross (8.2.0) does not support the f-string syntax with For now we need to use this syntax instead in order to make mpy-cross happy: It's possible that some future version of mpy-cross would support this in which case we could remove the exclusion from here and use the f-string syntax. I noticed there are newer mpy-cross |
|
I tested and confirmed that the f-string syntax does work with mpy-cross 9.x. So, after we make a final 8.x bundle we could switch back to the f-string syntax and remove the exclusion. |
|
Whoops, thank you. Added the images with the latest commit. |
|
Nice catch, I think the image files are corrupted or something. I'll look into more later today and try to get them fixed. I'm not entirely sure of the cause though. The originals that exist in my local copy of the repo on this branch seem to be functional, I can view them in my OS basic image viewer app. When I download them from Github I end up with files that are different. I compared sha256 sum of one of the images and the downloaded one differs from the one in my local repo. The downloaded one does not render in my OS basic image viewer either. |
|
After some experimentation on another branch and a few tries committing to here I think I've figured this out. The I noticed that the broken version of the smallest image was exactly 1 byte smaller than the working version and made a guess that the difference was due to a line ending difference. I'm not exactly sure how to compare the raw bytes within the files but in another branch I tested the theory by removing that file then removing and re-adding the images. After doing that they were working correctly on the Github pages in the browser, and when I download them from Github they also work in my image viewer app. I also confirmed the sha256 hash of the downloaded file now matches the one in my local copy of the repo. The most recent commits to this branch remove the gitattributes file and then remove and re-add the images. They appear to be functioning correctly for me on this branch now as well. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.4.0 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#99 from RoaCode/comparator_settings Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_RFM#2 from FoamyGuy/msgpack_example Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.23.1 from 1.23.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#85 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Changes the repository to use Ruff instead of pylint / black.
Also adds 3 new png image files that have formats with support added by recent PRs and some comented out lines in the png example for the user to test with them if they wish.