9.0.0 compatibility and better typing for sockets #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpokusa
force-pushed
the
9.0.0-compatibility-and-better-typing
branch
from
712c570 to
f7d20b5
Compare
FoamyGuy
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
This looks good to me. I tested the new version successfully on a Feather S3 TFT with Beta.2.
Thanks for the improvements @michalpokusa
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 25, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.5.6 from 4.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#84 from michalpokusa/9.0.0-compatibility-and-better-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪛Fixes:
FileResponsewas throwing uncaught error it someone did not provideroot_pathto both server and response constructor🛠️ Updated/Changed:
Server.startandServer.serve_forevernow use0.0.0.0as default host and5000as default port, I also changed it in docsSO_REUSEADDRit used in Python or CircuitPython above 9.0.0 which resolves CircuitPython 9.0.0 will require SO.REUSEADDR for socket reuse #83🏗️ Refactor:
socketpoolorwifimodules__repr__methods are now more like standard Python, so<Server ...>instead ofServer(...)