New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose nina-fw's getTime #67

Merged

brentru merged 1 commit into adafruit:master from brentru:add-get-time

Aug 22, 2019

Member

brentru commented Aug 22, 2019

Exposing getTime function to fetch latest unix timestamp.

get_time will raise an error if the ESP32 module is not connected to WiFi before the method is called.


          Expose WiFiNINA NTP Time

2e02cd8

brentru requested a review from a team

August 22, 2019 19:50

ladyada approved these changes

View reviewed changes

brentru merged commit 0d382ef into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@9869a7c)

ff27a86

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#37 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADT7410 to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADT7410#3 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#13 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#12 from s-light/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#36 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#31 from peterhinch/rename-reset

Updating https://github.com/adafruit/Adafruit_CircuitPython_CAP1188 to 1.1.2 from 1.1.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_CAP1188#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.1.6 from 1.1.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#34 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#32 from caternuson/minor_tweaks
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#31 from caternuson/fix_lint
  > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#30 from caternuson/remove_temp

Updating https://github.com/adafruit/Adafruit_CircuitPython_DRV2605 to 1.0.3 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DRV2605#16 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.9.0 from 1.8.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#67 from brentru/add-get-time

Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXAS21002C to 2.0.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXAS21002C#8 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_FXOS8700 to 2.0.0 from 1.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_FXOS8700#11 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.0.4 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#15 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.2.3 from 3.2.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#18 from tannewt/remove_stop
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#17 from adafruit/revert-16-add-blinka-to-requirements-txt
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#16 from demophoon/add-blinka-to-requirements-txt

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 1.3.1 from 1.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#11 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.0.3 from 2.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#19 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.1.4 from 3.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#13 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#22 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP006 to 2.0.0 from 1.0.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP006#5 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TMP007 to 2.0.0 from 1.0.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TMP007#5 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#25 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.1.3 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#10 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.0.0 from 3.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#30 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.7.2 from 1.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#27 from tannewt/remove_stop

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_JWT, Adafruit_CircuitPython_NTP

Contributor

mscosti commented Aug 23, 2019

I'm assuming this doesn't work if you're in AP mode and do not have an internet connection? or does the ESP32 actually have a hardware clock?

Member

ladyada commented Aug 23, 2019

it does ntp so yes network required!

Member Author

brentru commented Aug 23, 2019

@mscosti I didn't implement a check for AP mode, only if it's connected to WiFi. Do you want to add a PR to raise an error if it's in AP mode?

The ESP32 doesn't have an internal clock, the NTP is set to a fixed url here: https://github.com/adafruit/nina-fw/blob/master/arduino/libraries/WiFi/src/WiFi.cpp#L577

Contributor

mscosti commented Aug 24, 2019

👍 Sure thing, I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet