-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
off by one adjustments #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix alignment so all 122x250 pixels are available
ladyada
approved these changes
Dec 1, 2024
dhalbert
requested changes
Dec 1, 2024
Co-authored-by: Dan Halbert <[email protected]>
power_up() * voltages * border waveform * RAM X/Y COUNT had been dropped during 'z' troubleshooting, but test clean now so added back to match SSD1680 behavior.
This is working for me now (using same test setup/steps outlined on #85) |
@joxl - Thank you for testing. @ladyada or @dhalbert ready for release update. Myself, another forum user and @joxl have tested this library for alignment compatibility and it is working as expected. |
ladyada
approved these changes
Dec 3, 2024
thanks @FoamyGuy can bump it :) |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 10, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_AD569x to 2.0.5 from 2.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_AD569x#5 from adafruit/reset_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP3XX to 1.3.21 from 1.3.20: > Merge pull request adafruit/Adafruit_CircuitPython_BMP3XX#25 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.18 from 1.0.17: > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#9 from caternuson/iss8 Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.13.1 from 2.13.0: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#84 from mikeysklar/1680z-alignment Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.11.12 from 0.11.11: > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#26 from jposada202020/adding_displayIO_example Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 3.1.21 from 3.1.20: > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#26 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.3.0 from 1.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_datetime#27 from FoamyGuy/isoformat_Z_parse Updating https://github.com/adafruit/Adafruit_CircuitPython_FancyLED to 1.4.21 from 1.4.20: > Merge pull request adafruit/Adafruit_CircuitPython_FancyLED#31 from FoamyGuy/use_ruff Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.3.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#73 from adafruit/side-set-pindirs-directive Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.2 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#48 from FoamyGuy/visible_turtle_loc_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix alignment so all 122x250 pixels are available
test with full white, black, rectangle edge draw and weather.py examples
looks good and brings new 1680z functionality closer to previous 1680 model.