-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added ssd1680z 2.13 eink bonnet #83
Conversation
can you subclass the SSD1680 with only the updates added? |
A subclass seems reasonable. The changes are minor. It would be different than what was done with the SSD1675 vs SSD1675b, for example, which each have their own. I only have the newer SSD1680z eink hardware so I thought it might be safer to breakout the library to prevent breaking the original SSD1680. |
ok thanks, tag me again when done! |
dropped separate ssd1680z lib for a combined 1680 + 1680z.
@ladyada - SSD1680z sub-class tested with weather example along with my blank white / black / grid patterns. All pass. Key difference with initialization is:
|
can you undo the deletions from the original code? just add the subclass at the end plz 🙏 |
Sure, that makes more sense. Reverting back to original plus subclass addition at the bottom. |
plus 1680Z subclass at bottom
@ladyada - All script checks pass (blank, black, grid, weather). The weirdest part is that its 72F today and Manhattan. I had to go verify that on-line. |
thanks this is fine now! |
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.13.0 from 2.12.3: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#83 from mikeysklar/ssd1680z Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
It looks like there are several display commands in the old
I'm curious if these commands just aren't needed anymore (on the |
_SSD1680_DRIVER_CONTROL, | ||
bytearray([self._height - 1, (self._height - 1) >> 8, 0x00]), | ||
) | ||
self.command(_SSD1680_DATA_MODE, bytearray([0x03])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm understanding the chart in the PR description (and quoted below) correctly, shouldn't the value for this _SSD1680_DATA_MODE
command be 0x01
?
Feature/Command SSD1680 Library SSD1680Z Library Data Entry Mode bytearray([0x03])
bytearray([0x01])
... ... ...
I'm not familiar with these chips (yet), so I'm still trying to figure out where the old vs new values came from. If you could share any pointers regarding where/how you found the new values, it would be much appreciated!
The Adafruit 2.13" eink bonnet has been through several revisions. The most recent uses the GDEY0213B74 which uses a SSD1680z chip.
The differences are minor, but created some edge drawing problems. This ssd1680z accounts for the following changes.
I've included some an example grid demo code as this change warrants additional testing and feedback. The display init is only showing complete redraw with the width set to 128 (only 122 pixel). That still needs to be resolved.