-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct temperature readings for defective ICs + misc. improvements #6
Conversation
hmm, the PR's automatic test fails at "Check formatting", no idea why. Would need some help here... |
@kattni can help you get it formatted |
@taradiddles the CI system automatically checks the code with PyLint as well as Black code formatter. You can learn about them and how to use it on your Circuit Python code in the learn guide here: https://learn.adafruit.com/improve-your-code-with-pylint |
@taradiddles As @FoamyGuy said, follow the instructions in the guide. Run |
looks great, its ready for testing now |
@ladyada I've got one. I'll give it a whirl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the help.
One small request and it's good to go.
Also @taradiddles feel free to add yourself to the authors 👍
adafruit_dps310.py
Outdated
@@ -296,11 +314,39 @@ def temperature_ready(self): | |||
"""Returns true if there is a temperature reading ready""" | |||
return self._temp_ready | |||
|
|||
def wait_temperature_ready(self): | |||
"""Wait until a temperature measurement is available""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a note to the docstrings for the wait_nnn_ready
methods about which modes are supported so that hapless meteorologists aren't ambushed by wild Errors
🐅
@siddacious: ready... Had to learn a bit about docstrings and sphinx, hopefully everything's OK.
Thank you ; maybe next time... (at least once I know python a bit better) |
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.0.1 from 5.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#49 from russmac/master Updating https://github.com/adafruit/Adafruit_CircuitPython_DPS310 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_DPS310#6 from taradiddles/master Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.2 from 3.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#19 from colindgrant/powerdown-constant-spelling Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 3.2.0 from 3.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#35 from brentru/add-cellular-example Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 6.1.4 from 6.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_BLE#81 from dhalbert/max_length Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_LIS331, Adafruit_CircuitPython_BLE_Adafruit
the changes above shouldn't break code using this library, maybe with the exception of wait_{temperature,pressure}_ready() which throw an exception when the mode isn't properly set in order to avoid infinite waits (but in that case such code would be broken/non-functional anyway).