CP: more configuration options for the tap detection #99
Conversation
There was a problem hiding this comment.
Thank you so much for adding this! Tap can be finicky on a good day, so I understand your need for it. Please see the requested changes below - no functional changes requested, it's all documentation or clarification. If you need assistance, please let me know, I'm happy to help.
FYI: The reason the latest CircuitPython is not working properly is that one of the frozen libraries necessary for the CircuitPlayground library to work was removed, because the library was moved into the core CircuitPython code. However, there were issues with it in the core, therefore it was disabled, and the sweep to add it back to the frozen library lists for necessary boards missed the Circuit Playground builds. There is a PR in to resolve this issue, and once merged, building CircuitPython from main should work again.
|
@mw46d Can you post your test code here? I'd really appreciate it. |
|
@mw46d Apologies for the delay. I have been pulled into a high priority project that I need to get through before I can circle back to this. I will get to it as soon as possible. I took care of a merge conflict from an update we applied to the library, hopefully everything still passes with the conflict resolution. |
|
It failed. The issue is that the latest version of black needs to be run on the circuitplayground_base.py file, and those changes pushed. @mw46d If this is not something you're familiar with or comfortable with, I'll take care of it when I circle back to review. Otherwise, if you are comfortable with it, feel free to run black and push the changes to this PR. |
There was a problem hiding this comment.
Thank you so much for your patience!
I like the changes you made from your initial iteration. Nice job!
I will note that the values in your example are hypersensitive and detect taps when there are none, but I suppose that's the entire point is to allow tweaking to avoid that.
Tested successfully on Circuit Playground Express. Verified that it fits into CircuitPython builds with these changes as well, so we're good there.
Thanks again!
Updating https://github.com/adafruit/Adafruit_CircuitPython_CharLCD to 3.3.6 from 3.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_CharLCD#56 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 4.3.0 from 4.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#102 from adafruit/dherrada-patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#101 from kattni/cleanup-deprecated-code > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#99 from mw46d/main Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.0.3 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#43 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#11 from askpatrickw/fix-repo-url-typo Updating https://github.com/adafruit/Adafruit_CircuitPython_MPR121 to 2.1.5 from 2.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_MPR121#30 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Nunchuk to 1.0.0 from 0.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_Nunchuk#24 from jfurcean/add-values-property Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM9x to 2.1.2 from 2.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_RFM9x#59 from AdamLeyshon/add_snr_property Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.9.0 from 1.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#31 from xorbit/master Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.1.0 from 5.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#62 from brentru/create-group-feed > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#61 from brentru/small-feed-names > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#60 from askpatrickw/fix-repo-url-typos Updating https://github.com/adafruit/Adafruit_CircuitPython_AVRprog to 1.3.4 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_AVRprog#20 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.2.5 from 3.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#51 from adafruit/dherrada-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#58 from askpatrickw/fix-repo-typo > Added pre-commit-config file Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_datetime
The CircuitPython code did not allow me to configure the tap detection for what I needed:-(
This pull request was updated to master!
My test system was actually CircuitPython 6.0.1 on a CPX, the the master/beta branch of CircuitPython did not seem to work well on that board:-(
I'm not really particular about the method name or anything. But I could not find a compatible way to extend the property setter:-(