Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional dependencies to pyproject.toml #58

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Feb 4, 2023

Added optional dependencies to pyproject.toml, which aren't currently used now but this format is consistent across the other libraries. This will make adabot patching more reliable, at least, should that be needed.

Fixes #57

@tekktrik tekktrik added the bug label Feb 4, 2023
@tekktrik tekktrik requested a review from a team February 4, 2023 18:15
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM. Changes are aligned with other Adafruit libraries. Thanks :)

@tekktrik tekktrik merged commit b1b4bc8 into adafruit:main Feb 4, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 5, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.4.12 from 3.4.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME680#58 from tekktrik/dev/add-opp-deps
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.2.7 from 1.2.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#35 from Neradoc/documentation-for-raw-text-packet
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.4.8 from 3.4.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_Motor#70 from makermelissa/master
  > Add upload url to release action

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
@tekktrik tekktrik deleted the dev/add-opp-deps branch January 15, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyproject.toml missing optional_dependencies
2 participants