Use correct value to compute gas resistance #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is supposed to be a 1:1 translation from Bosch C library https://github.com/boschsensortec/BME68x-Sensor-API/blob/6dab330cb5727006d5046f9eebf357f8909c0ef6/bme68x.c#L971. There they do: ```C /* multiplying 10000 then dividing then multiplying by 100 instead of multiplying by 1000000 to prevent overflow */ calc_gas_res = (UINT32_C(10000) * var1) / (uint32_t)var2; calc_gas_res = calc_gas_res * 100; ``` With the current code resistance is off by a factor of 10
|
Agree that sure looks like a typo. And Not seeing the factor of 10 being accounted for elsewhere. Was this discovered by just code inspection? Or did you notice bad values when using the library? |
FoamyGuy
approved these changes
Aug 7, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 8, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.6.0 from 3.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#56 from patcher-ms/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.18.0 from 1.17.3: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#71 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_USB_Host_Descriptors Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is supposed to be a 1:1 translation from Bosch C library https://github.com/boschsensortec/BME68x-Sensor-API/blob/6dab330cb5727006d5046f9eebf357f8909c0ef6/bme68x.c#L971.
There they do:
With the current code resistance is off by a factor of 10