Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for startup message if no uart #11

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Don't check for startup message if no uart #11

merged 1 commit into from
Jun 3, 2024

Conversation

dhalbert
Copy link
Contributor

Also fix documentation typos.

Tested on a PyPortal. The start_wifi() has limited utility because it doesn't work together with the ESP32SPI library. That's something else to think about in the future.

@dhalbert dhalbert requested a review from a team May 23, 2024 20:39
FoamyGuy
FoamyGuy approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the fix.

I did a quick test of the simpletest successfully.

@FoamyGuy FoamyGuy merged commit 6dc519b into adafruit:main Jun 3, 2024
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 11, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d723e94)
64cda02 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.5 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#25 from karlfl/Use_All_Mask_Filter_Pairs

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.1.5 from 2.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#40 from purepani/add_exit_before_rt

Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90640 to 1.3.2 from 1.3.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MLX90640#32 from adafruit/stemma_i2c

Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.14 from 1.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#11 from dhalbert/fix-start-wifi

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 3.1.1 from 3.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#206 from SamantazFox/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start_wifi(): ESP32 did not respond with a startup message
2 participants
@dhalbert @FoamyGuy