New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type hints and docstrings #31

Merged

FoamyGuy merged 5 commits into adafruit:main from brass75:issue_25/missing-typehints

May 1, 2023

brass75 commented Apr 24, 2023

Fixes #25

Dan Shernicoff added 4 commits

April 24, 2023 11:01


          Improve type hints and docstrings

a737878


          Black formatting

77c0c2c


          Fix lint error

9a3f2f4


          fix another lint error

d9944ce

tekktrik requested a review from a team

April 24, 2023 18:42

FoamyGuy requested changes

View reviewed changes

Contributor

FoamyGuy left a comment

Thanks for working on this @brass75!

I have a few suggested changes.

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc_asn1.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc_asn1.py Outdated Show resolved Hide resolved

adafruit_atecc/adafruit_atecc_asn1.py Outdated Show resolved Hide resolved


          PR feedback

69de468

Author

brass75 commented May 1, 2023

Thanks @FoamyGuy . I think I got all the changes you requested.

brass75 requested a review from FoamyGuy

May 1, 2023 20:04

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

Latest version looks good to me. Thanks again @brass75.

FoamyGuy merged commit 7697a02 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@a52bbea)

166dfa4

Updating https://github.com/adafruit/Adafruit_CircuitPython_ATECC to 1.2.17 from 1.2.15:
  > Merge pull request adafruit/Adafruit_CircuitPython_ATECC#33 from FoamyGuy/fix_docs
  > Merge pull request adafruit/Adafruit_CircuitPython_ATECC#31 from brass75/issue_25/missing-typehints
  > Add upload url to release action
  > Add .venv to .gitignore
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.3.0 from 2.2.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#25 from jrrickerson/config_voltage_alarm

Updating https://github.com/adafruit/Adafruit_CircuitPython_RockBlock to 1.3.12 from 1.3.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_RockBlock#30 from zachariahpifer/add-type-annotations
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.3.17 from 3.3.16:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#42 from zemyblue/feat/support_tcs34727
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#25 from CedarGroveStudios/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 2.5.0 from 2.4.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#95 from BiffoBear/new_dhcp_state_machine

Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.2.0 from 2.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#44 from kalehmann/feature/display_sleep
  > Add upload url to release action
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 3.0.10 from 3.0.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#67 from RossK1/adding_type_hints
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet