Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ref docs #5

Merged
merged 4 commits into from
Feb 22, 2018
Merged

Improved ref docs #5

merged 4 commits into from
Feb 22, 2018

Conversation

brentru
Copy link
Member

@brentru brentru commented Feb 21, 2018

Improved reference documentation + following the guidelines set in:
adafruit/circuitpython#566

Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please let me know about the question below. Thanks!

Ensure your device works with this test:

.. literalinclude:: ../examples/pixel_test.py
:caption: examples/pixel_test.py.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You updated the literalinclude to remove the extra .py but not the caption. Was this intentional?

Copy link
Member Author

@brentru brentru Feb 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unintentional, the extra .py should've been removed in the caption as well..corrected.

@kattni kattni merged commit 0554b5b into adafruit:master Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants