Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue32 add type annotations #35

Merged
merged 6 commits into from
Feb 12, 2022
Merged

Issue32 add type annotations #35

merged 6 commits into from
Feb 12, 2022

Conversation

tammymakesthings
Copy link
Contributor

Fixes issue #32

  • Added type annotations to adafruit_amg88xx.py

tekktrik
tekktrik requested changes Feb 12, 2022
View reviewed changes
@tekktrik
Copy link
Member

tekktrik commented Feb 12, 2022 •
edited
Loading

@FoamyGuy I think there's no harm in having the RWBit and RWBits imports outside of the try/except block here because they would have already been imported as part of from adafruit_register import i2c_bit, i2c_bits but not completely sure about that. Thoughts?

tekktrik
tekktrik requested changes Feb 12, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick update to __init__(), but otherwise looks great! I still think it's fine for the direct import of RWBit and RWBits outside of the try/except since I don't think it actually uses any more RAM (at least in CPython)

tekktrik
tekktrik approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you so much!

@tekktrik tekktrik linked an issue Feb 12, 2022 that may be closed by this pull request
Missing Type Annotations #32
Closed
3 tasks
@tekktrik tekktrik merged commit 02d72c5 into adafruit:main Feb 12, 2022
@tammymakesthings tammymakesthings deleted the issue32-add-type-annotations branch February 13, 2022 17:05
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 18, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@8ce3914)
4665222 
Updating https://github.com/adafruit/Adafruit_CircuitPython_AHTx0 to 1.0.10 from 1.0.9:
  > Fixed readthedocs build
  > Merge pull request adafruit/Adafruit_CircuitPython_AHTx0#11 from tammymakesthings/issue9-add-type-annotations
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AMG88xx to 1.2.11 from 1.2.10:
  > Fixed readthedocs build
  > Merge pull request adafruit/Adafruit_CircuitPython_AMG88xx#35 from tammymakesthings/issue32-add-type-annotations
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_AS7341 to 1.2.5 from 1.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#27 from tekktrik/doc/reveal-gain-class
  > Merge pull request adafruit/Adafruit_CircuitPython_AS7341#25 from tammymakesthings/update-requirements-for-typing

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.8 from 1.0.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO08x_RVC#5 from tekktrik/doc/add-typing
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.3 from 4.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#51 from lstein/decode-bug-fix
  > Fixed readthedocs build
  > Consolidate Documentation sections of README

Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Radio to 0.5.1 from 0.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Radio#22 from infamy/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tammymakesthings @tekktrik