New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix example code in readme #3

Merged

FoamyGuy merged 1 commit into adafruit:main from FoamyGuy:fix_readme_example

Dec 11, 2024

Contributor

FoamyGuy commented Dec 5, 2024

@ladyada
Resolves: #2


          fix example code in readme

5488c3a

ladyada approved these changes

View reviewed changes

Member

ladyada left a comment

did you test this?

Contributor Author

FoamyGuy commented Dec 5, 2024

@ladyada No, I don't have the hardware.

It's just taken from the issue comment.

Member

ladyada commented Dec 5, 2024

ok all PRs should be tested before we can merge, folks are often wrong, dont trust internet strangers :)

Contributor Author

FoamyGuy commented Dec 11, 2024

I've now tested on a QTPY s3. Confirmed the existing code in Readme raises the exception noted and the new version runs and behaves correctly.

FoamyGuy merged commit 9924458 into adafruit:main

1 check passed

Member

ladyada commented Dec 11, 2024

yay

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@53e7906)

a2f2a77

Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS7830 to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_ADS7830#3 from FoamyGuy/fix_readme_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.3.4 from 3.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#44 from FoamyGuy/simpletest_cs_pin

Updating https://github.com/adafruit/Adafruit_CircuitPython_ENS160 to 1.0.9 from 1.0.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_ENS160#6 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_HDC302x to 1.0.2 from 1.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_HDC302x#3 from FoamyGuy/remove_print

Updating https://github.com/adafruit/Adafruit_CircuitPython_ICM20X to 2.1.4 from 2.1.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ICM20X#28 from FoamyGuy/units_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.2.2 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#22 from jposada202020/adding_displayio_example

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet