Adding library and example #1
Conversation
adafruit_ads7830.py
Outdated
| @property | ||
| def value(self) -> typing.List[int]: | ||
| """Single-ended mode ADC values for all channels | ||
|
|
||
| :rtype: List[int]""" | ||
| values = [] | ||
| for i in range(8): | ||
| single_value = self._single_channel(i) | ||
| values.append(single_value) | ||
| return values | ||
|
|
||
| @property | ||
| def differential_value(self) -> typing.List[int]: | ||
| """Differential ADC values for all channel pairs | ||
|
|
||
| :rtype: List[int]""" | ||
| values = [] | ||
| for i in range(0, 8, 2): # Iterate over channel pairs | ||
| diff_value = self._differential_channel(i) | ||
| values.append(diff_value) | ||
| return values |
There was a problem hiding this comment.
I wouldn't have these read every value, every time because that'll be slow and do a bunch of work that the user may not need. Instead, take a look at this library: https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx/tree/main/adafruit_mcp3xxx
It provides a way to get the value directly and also has an AnalogIn compatibility class too.
There was a problem hiding this comment.
awesome, thanks! that was really helpful to reference
There was a problem hiding this comment.
One more suggestion to remove the power down list. It isn't needed for verification or mapping.
Another thing to think about is the parameter naming (adc_pd for example). Using truncated words can make it harder to understand on its own. Full words tend to be easier to understand.
adafruit_ads7830/ads7830.py
Outdated
| self.power_down = 0 | ||
| if not int_ref_power_down: | ||
| self.power_down |= 2 | ||
| if not adc_power_down: | ||
| self.power_down |= 1 |
There was a problem hiding this comment.
My example used a temporary variable because this will do reads and writes over i2c for each access.
Co-authored-by: Scott Shawcroft <[email protected]>
Adding library and example for the ADS7830 ADC (https://www.adafruit.com/product/5836). Arduino library: https://github.com/adafruit/Adafruit_ADS7830