GaussianGridTrackDensity Vertex Finder #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalzburger
reviewed
Apr 3, 2020
asalzburger
reviewed
Apr 3, 2020
baschlag
force-pushed
the
gaussian_trackdensity_grid_finder
branch
3 times, most recently
from
eb5fa91 to
4896f4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 44.66% 44.66%
=======================================
Files 369 369
Lines 18454 18454
Branches 8782 8782
=======================================
Hits 8243 8243
Misses 4874 4874
Partials 5337 5337 Continue to review full report at Codecov.
|
baschlag
force-pushed
the
gaussian_trackdensity_grid_finder
branch
from
4896f4c to
f8d96c3
Compare
baschlag
changed the title
|
Removed WIP flag, should be ready from my side. |
|
Just two performance plots: Vertex z-position resolution (in mm): |
baschlag
force-pushed
the
gaussian_trackdensity_grid_finder
branch
2 times, most recently
from
883fff3 to
28d60f0
Compare
|
I've added functionality to estimate the seed width in z-direction based on the FWHM of the density peak. |
|
Hi @robertlangenberg, if I remember correctly, you volunteered to review this PR, right? I'm going to rebase it now and then it's ready to be reviewed from my side. |
…unit test for track removal
…Finder is of correct type
…inder and unit test
robertlangenberg
suggested changes
May 18, 2020
baschlag
force-pushed
the
gaussian_trackdensity_grid_finder
branch
from
8870055 to
3142348
Compare
|
All comments have been addressed @robertlangenberg |
robertlangenberg
approved these changes
May 18, 2020
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
* inital GaussianGridDensity commit * use only vector at z-axis instead of full grid, add tracks to the grid * add more tests for upper and lower boundary checks and remove printouts * add method to retrieve maximum density value * add GridDensityVertexFinder and unit test * remove unecessary cov matrices in unit test * add method to remove track density from grid * addTrack returns pair of zBin and trackGrid to allowing caching, add unit test for track removal * add second find method to allow caching of track density values in finder state * implement proper usage of track density removal if caching enabled in trackdensity grid finder * add unit test for testing cache track density removal * introduce vertex finder state for consistency reasons to all vertex finders and add unit test for GridDensitySeedFinder in AMVF * save deletedSeedTracks in vector and pass to seedFinder state if seedFinder is of correct type * bug fix, track density removal now working * adapt AMVF unit test to finder state change after rebase * use constraint vertex correctly in grid density finder and handle empty grid properly * add grid seed finder resolution and time to debug output * add track selection and option to use highest sum track density, add more docs * fix format * add unit test for AMVF with gaussian grid finder * adapt vertexing example algorithm to finder state changes * remove unwanted secondary vertices from Examples/VertexFitAlgorithm * add config constructor with custom grid density to GridDensityVertexFinder and unit test * add unit test for GaussianGridTrackDensity max sum density option * add seed width calculation to grid finder * fix format and and unit test for grid finder seed witdh calculation * remove test root input unit test * update docs * return 0 width for failed seed width estimation * remove commented out code * make vertexing fit transverse distance configurable * rename method to remove incompatible track in AMVF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation about the actual algorithm will be added soon.