Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add codecov tolerance threshold of 0.1% #79

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add codecov tolerance threshold of 0.1% #79

merged 1 commit into from
Mar 30, 2020

Conversation

paulgessinger
Copy link
Member

This should allow for small changes that we don't care about.
See #72.

@paulgessinger paulgessinger added Infrastructure Changes to build tools, continous integration, ... and removed Triage labels Mar 30, 2020
@paulgessinger paulgessinger mentioned this pull request Mar 30, 2020
Merged
asalzburger
asalzburger approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good change, if above 0.1 % we either need to manually overwrite or the author should add more testing code.

@paulgessinger paulgessinger added this to the 0.21.00 milestone Mar 30, 2020
@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #79   +/-   ##
=======================================
  Coverage   42.55%   42.55%           
=======================================
  Files         348      348           
  Lines       16637    16637           
  Branches     7907     7907           
=======================================
  Hits         7080     7080           
  Misses       4893     4893           
  Partials     4664     4664

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81560c...67e4322. Read the comment docs.

@asalzburger asalzburger merged commit e918a93 into acts-project:master Mar 30, 2020
@acts-issue-bot acts-issue-bot bot removed the Triage label Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Milestone
v0.21.00
Development

Successfully merging this pull request may close these issues.
2 participants
@paulgessinger @asalzburger