Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: shorten parameter enum and related type names #420

Merged
merged 6 commits into from
Sep 2, 2020

Conversation

msmk0
Copy link
Contributor

@msmk0 msmk0 commented Sep 1, 2020

This renames the following types

BoundParametersIndices -> BoundIndices
BoundParametersScalar -> BoundScalar
eBoundParametersSize -> eBoundSize
FreeParametersIndices -> FreeIndices
FreeParametersScalar -> FreeScalar
eFreeParametersSize -> eFreeSize

and replace the following previously deprecated typedefs with the correct types

ParDef -> BoundIndices
ParID_t -> BoundIndices
ParValue_t -> BoundScalar

Fixes #137 and fixes #407.

@msmk0 msmk0 added Component - Core Affects the Core module Improvement Changes to an existing feature Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins labels Sep 1, 2020
@msmk0 msmk0 added this to the v1.0.0 milestone Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #420 into master will increase coverage by 0.03%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   49.22%   49.26%   +0.03%     
==========================================
  Files         326      326              
  Lines       16083    16090       +7     
  Branches     7420     7418       -2     
==========================================
+ Hits         7917     7926       +9     
  Misses       2931     2931              
+ Partials     5235     5233       -2     
Impacted Files Coverage Δ
Core/include/Acts/EventData/Measurement.hpp 53.84% <ø> (ø)
...lude/Acts/EventData/SingleBoundTrackParameters.hpp 52.08% <ø> (ø)
...cts/EventData/SingleCurvilinearTrackParameters.hpp 28.57% <ø> (ø)
...clude/Acts/EventData/SingleFreeTrackParameters.hpp 54.83% <ø> (ø)
...lude/Acts/EventData/detail/residual_calculator.hpp 100.00% <ø> (ø)
Core/include/Acts/Fitter/GainMatrixUpdater.hpp 11.36% <0.00%> (ø)
Core/include/Acts/Propagator/AtlasStepper.hpp 71.39% <0.00%> (-0.04%) ⬇️
Core/include/Acts/Surfaces/detail/LineSurface.ipp 36.15% <0.00%> (+0.27%) ⬆️
Core/include/Acts/Surfaces/detail/Surface.ipp 71.83% <0.00%> (ø)
...include/Acts/Vertexing/GridDensityVertexFinder.ipp 47.22% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d6087f...374d556. Read the comment docs.

@msmk0 msmk0 requested a review from paulgessinger September 2, 2020 08:23
@msmk0
Copy link
Contributor Author

msmk0 commented Sep 2, 2020

@paulgessinger I request you as a reviewer since you were the one who was complaining about the long type names in the first place 😄

@paulgessinger
Copy link
Member

The replacements in the description seem fine to me. I trust you to be able to do search & replace so if it compiles, I'm ok to merge it.

@msmk0
Copy link
Contributor Author

msmk0 commented Sep 2, 2020

Yes, this is purely search and replace. I just saw that I need to do the same for the alignment parameter definitions. I will open another PR for this to avoid blocking this one any further.

@msmk0 msmk0 merged commit 4b476b8 into acts-project:master Sep 2, 2020
@msmk0 msmk0 deleted the 407-shorten-parameter-enums branch September 2, 2020 11:22
msmk0 added a commit that referenced this pull request Sep 3, 2020
…422_

This performs the following renames
```
AlignmentParametersIndices -> AlignmentIndices
AlignmentParametersScalar -> AlignmentScalar
eAlignmentParametersSize -> eAlignmentSize
```
for consistency with the similar parameter enums modified in #420.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Plugins Affects one or more Plugins Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shorten parameter enum and scalar types Remove obsolete parameter enum typedefs
2 participants