-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: shorten parameter enum and related type names #420
Conversation
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
==========================================
+ Coverage 49.22% 49.26% +0.03%
==========================================
Files 326 326
Lines 16083 16090 +7
Branches 7420 7418 -2
==========================================
+ Hits 7917 7926 +9
Misses 2931 2931
+ Partials 5235 5233 -2
Continue to review full report at Codecov.
|
@paulgessinger I request you as a reviewer since you were the one who was complaining about the long type names in the first place 😄 |
The replacements in the description seem fine to me. I trust you to be able to do search & replace so if it compiles, I'm ok to merge it. |
Yes, this is purely search and replace. I just saw that I need to do the same for the alignment parameter definitions. I will open another PR for this to avoid blocking this one any further. |
…422_ This performs the following renames ``` AlignmentParametersIndices -> AlignmentIndices AlignmentParametersScalar -> AlignmentScalar eAlignmentParametersSize -> eAlignmentSize ``` for consistency with the similar parameter enums modified in #420.
This renames the following types
and replace the following previously deprecated typedefs with the correct types
Fixes #137 and fixes #407.