chore: pre-commit check for type_t uses --fix

[paulgessinger]

--- END COMMIT MESSAGE ---

Any further description goes here, @-mentions are ok here!

• Use a conventional commits prefix: quick summary
  • We mostly use feat, fix, refactor, docs, chore and build types.
• A milestone will be assigned by one of the maintainers

Summary by CodeRabbit

• Chores
  • Enhanced the commit hook functionality to now automatically apply fixes during type checking, improving the overall code quality and stability process.

[coderabbitai]

Walkthrough

The pull request updates the .pre-commit-config.yaml file. It changes the entry field for the type_t hook from CI/check_type_t.py to CI/check_type_t.py --fix. This modification alters the hook’s behavior to execute the script with a --fix argument, potentially applying automatic fixes during pre-commit checks. The remainder of the configuration remains unchanged.

Changes

File	Change Summary
.pre-commit-config.yaml	Updated the type_t hook's entry from CI/check_type_t.py to CI/check_type_t.py --fix.

Sequence Diagram(s)

sequenceDiagram
    participant D as Developer
    participant PC as Pre-Commit
    participant HT as check_type_t.py
    D->>PC: Initiate commit
    PC->>HT: Execute hook with "--fix"
    HT-->>PC: Return result (auto-fix applied)
    PC->>D: Proceed with commit

Loading

Possibly related PRs

• ci: Lint updates #3958: Modified .pre-commit-config.yaml to update the codespell hook, similar in context to the current hook update.

Suggested labels

Infrastructure, automerge

Suggested reviewers

• AJPfleger

Poem

Changed, the hook has been, hmm!
--fix now it wields, powerful and bold.
Bugs flee, they do, from the force strong.
A new path in commits, our code does behold.
May the fixes be with you, always, yes!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 287bf22 and b338a8c.

📒 Files selected for processing (1)

• .pre-commit-config.yaml (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: merge-sentinel
• GitHub Check: unused_files
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, clang++)
• GitHub Check: missing_includes
• GitHub Check: macos
• GitHub Check: linux_ubuntu_extra (ubuntu2204, 20, g++)
• GitHub Check: build_debug
• GitHub Check: linux_ubuntu
• GitHub Check: docs

🔇 Additional comments (2)

.pre-commit-config.yaml (2)

73-73: Approve the addition of --fix flag, I do!

Hmmmm, wise decision this is. Like the license check hook at line 49, automatic fixes it will now attempt. Save time for developers, this change will.

---

68-74: Verify the script's fix capability, we must.

Before merging, ensure we must that check_type_t.py script, the --fix flag it supports. Break the build, we must not!

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify that check_type_t.py supports the --fix flag

# Test: Check if the script accepts --fix flag
python CI/check_type_t.py --help 2>&1 | grep -q "\-\-fix" && echo "Fix flag supported" || echo "Fix flag not found"

Length of output: 101

---

Script’s fix capability verified, it is.

The output shows that the check_type_t.py script includes the --fix flag support, as the help information confirms its inclusion. No further action is needed.

• CI/check_type_t.py confirms the availability of the --fix flag.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

📊: Physics performance monitoring for b338a8c

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• ✅ CKF finding performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• ✅ CKF finding performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• ✅ CKF finding performance | trackfinding | single muon | default seeding
• ✅ CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• ✅ CKF finding performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• ✅ Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• ✅ ML Ambisolver | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• ✅ AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[acts-project-service]

🔴 Athena integration test results [25969ed]

Build job with this PR failed!

Please investigate the build job for the pipeline!