Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix even more compiler warnings #301

Merged

Conversation

msmk0
Copy link
Contributor

@msmk0 msmk0 commented Jul 2, 2020

Fixes some more compiler warnings that show up in #267.

@msmk0 msmk0 added Bug Something isn't working Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels Jul 2, 2020
@msmk0 msmk0 added this to the v0.28.00 milestone Jul 2, 2020
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #301 into master will not change coverage.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #301   +/-   ##
=======================================
  Coverage   48.32%   48.32%           
=======================================
  Files         323      323           
  Lines       16368    16368           
  Branches     7606     7606           
=======================================
  Hits         7910     7910           
  Misses       3172     3172           
  Partials     5286     5286           
Impacted Files Coverage Δ
Core/include/Acts/Propagator/Propagator.ipp 35.86% <0.00%> (ø)
Core/include/Acts/Fitter/GainMatrixSmoother.hpp 12.76% <100.00%> (ø)
...re/include/Acts/Vertexing/GaussianTrackDensity.hpp 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0b9342...bf97f43. Read the comment docs.

@paulgessinger paulgessinger merged commit 74135dc into acts-project:master Jul 3, 2020
@msmk0 msmk0 deleted the fix-even-more-compiler-warnings branch July 9, 2020 13:59
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 13, 2020
Fixes some more compiler warnings that show up in acts-project#267.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants