Make the material classification numbers an opaque vector #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msmk0
added
Component - Core
msmk0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 48.26% 48.32% +0.05%
==========================================
Files 323 323
Lines 16367 16368 +1
Branches 7606 7606
==========================================
+ Hits 7900 7910 +10
+ Misses 3181 3172 -9
Partials 5286 5286
Continue to review full report at Codecov.
|
msmk0
force-pushed
the
opaque-material-classification-numbers
branch
from
c1a4149 to
37bb2bd
Compare
paulgessinger
previously approved these changes
Jul 2, 2020
|
Ah nevermind, it's in the |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
…ct#299) Remove the public `enum` within the `Material` class that describes the content of the classification numbers vector. The classification numbers can still be used to stored the encoded material information. In order to interpret it, a `Material` object has to be constructed again. The functionality was no used in the code base and removing it will make it easier to change the internal parametrization as planned in acts-project#31. Should also fix compiler warning regarding enum name clashes that show up in acts-project#267.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the public
enumwithin theMaterialclass that describes the content of the classification numbers vector. The classification numbers can still be used to stored the encoded material information. In order to interpret it, aMaterialobject has to be constructed again.The functionality was no used in the code base and removing it will make it easier to change the internal parametrization as planned in #31. Should also fix compiler warning regarding enum name clashes that show up in #267.