Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warning in VerticesHelper #295

Merged
merged 3 commits into from
Jun 30, 2020
Merged

Fix compiler warning in VerticesHelper #295

merged 3 commits into from
Jun 30, 2020

Conversation

msmk0
Copy link
Contributor

@msmk0 msmk0 commented Jun 30, 2020

Move non-template function implementations to a .cpp file. This fixes compiler warnings that appear with #267.

@msmk0 msmk0 added Bug Something isn't working Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module labels Jun 30, 2020
@msmk0 msmk0 added this to the v0.28.00 milestone Jun 30, 2020
@msmk0 msmk0 requested a review from paulgessinger June 30, 2020 09:02
@msmk0 msmk0 force-pushed the fix-vertices-helper branch 2 times, most recently from 67ea15e to c7970ef Compare June 30, 2020 09:17
@msmk0 msmk0 force-pushed the fix-vertices-helper branch from c7970ef to 46fd4c7 Compare June 30, 2020 09:19
@codecov
Copy link

codecov bot commented Jun 30, 2020 •
edited
Loading

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is 54.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   48.31%   48.31%           
=======================================
  Files         324      325    +1     
  Lines       16427    16427           
  Branches     7633     7633           
=======================================
  Hits         7937     7937           
  Misses       3184     3184           
  Partials     5306     5306
Impacted Files Coverage Δ
...re/include/Acts/Surfaces/detail/VerticesHelper.hpp 51.61% <ø> (-1.96%) ⬇️
Core/src/Surfaces/EllipseBounds.cpp 52.70% <ø> (ø)
Core/src/Surfaces/VerticesHelper.cpp 54.71% <54.71%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 893a452...9ef2a03. Read the comment docs.

@msmk0
Copy link
Contributor Author

msmk0 commented Jun 30, 2020

@paulgessinger All issues should be resolved now.

@paulgessinger paulgessinger merged commit a9a3883 into acts-project:master Jun 30, 2020
@msmk0 msmk0 deleted the fix-vertices-helper branch July 2, 2020 07:39
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 13, 2020
@msmk0 @paulgessinger
Fix compiler warning in VerticesHelper (acts-project#295)
ece2611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulgessinger paulgessinger paulgessinger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Milestone
v0.28.00
Development

Successfully merging this pull request may close these issues.
2 participants
@msmk0 @paulgessinger