Remove TrackState #289
Merged
Remove TrackState #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianKlimpel
added
Component - Core
FabianKlimpel
added
Improvement
There was a problem hiding this comment.
Ok I think generally this is fine, definitely want @XiaocongAi's opinion on this though.
msmk0
suggested changes
Jun 26, 2020
FabianKlimpel
force-pushed
the
RemoveTrackState
branch
from
9eda209 to
0d52542
Compare
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 48.33% 48.26% -0.08%
==========================================
Files 325 323 -2
Lines 16444 16367 -77
Branches 7643 7606 -37
==========================================
- Hits 7949 7900 -49
+ Misses 3183 3181 -2
+ Partials 5312 5286 -26
Continue to review full report at Codecov.
|
FabianKlimpel
force-pushed
the
RemoveTrackState
branch
2 times, most recently
from
9169b8a to
47b5023
Compare
msmk0
approved these changes
Jun 30, 2020
|
Let's hold this for @XiaocongAi to have a look. |
FabianKlimpel
force-pushed
the
RemoveTrackState
branch
from
47b5023 to
6a615e8
Compare
|
@XiaocongAi Could you have a look at this and let us know if you see any blockers or whether we can merge it? |
|
This looks good to me. I will approve. |
XiaocongAi
approved these changes
Jul 1, 2020
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
The TrackState is not in use anymore and became superseded by the MultiTrajectory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TrackStateis not in use anymore and became superseded by theMultiTrajectory. Herewith I propose with the PR to remove it from the code base.