Fix narrowing conversions in Result Test #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Result related warnings surfaced in acts-project#267. They are due to `Result<double>` being assigned integer literals, which `Result` just passes through. This is what the compiler complains about then.
msmk0
approved these changes
Jun 24, 2020
msmk0
approved these changes
Jun 24, 2020
|
Hm. Does the coverage job run out of disk space again? |
|
I'm overriding the failing coverage job. |
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
* Fix narrowing conversions in Result Test Fixes Result related warnings surfaced in acts-project#267. They are due to `Result<double>` being assigned integer literals, which `Result` just passes through. This is what the compiler complains about then. * Format fix Co-authored-by: Moritz Kiehn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Result related warnings surfaced in #267. They are due to
Result<double>being assigned integer literals, whichResultjust passes through. This is what the compiler complains about then.