fixed two bug for the GeantinoRecording #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Bug
asalzburger
approved these changes
Jun 23, 2020
|
I triggered the rebuild for |
It used to be like that on gitlab but was changed afterward so I just reverted back to that. If we want we could discuss how to change it. |
msmk0
reviewed
Jun 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
+ Coverage 44.84% 48.38% +3.53%
==========================================
Files 376 318 -58
Lines 18866 16366 -2500
Branches 8970 7586 -1384
==========================================
- Hits 8461 7918 -543
+ Misses 4905 3180 -1725
+ Partials 5500 5268 -232
Continue to review full report at Codecov.
|
msmk0
approved these changes
Jun 23, 2020
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Jul 13, 2020
* fixed two bug for the GeantinoRecording * format * format * move the m_materialTracks.clear() into EventAction::clear() * put back the mapper as they where... * put the return back * removed commented line * format Co-authored-by: Moritz Kiehn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved two bug related to Geantino scan.
The first one in RunSimGeantinoRecording.cpp was related to writer being set using a variable hat had already been moved.
The second to the fact that the type written by the EventAction didn't match the one wrtote by the writer. In addition the recorded material where not deleted from one event to the other.