Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional write out detailed matching infos in CKFPerformanceWriter #2733

Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Nov 27, 2023

Needed for GNN+CKF workflow.
Optionally writes additional info to a TTree like this:

      event_nr         particle_id  matched
0            2    4503599677702144     True
1            2    4503599862251520     True
2            2    4503599929360384     True
3            2    4503599946137600    False
...

@benjaminhuth benjaminhuth added this to the next milestone Nov 27, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Nov 27, 2023
@benjaminhuth benjaminhuth marked this pull request as draft November 27, 2023 17:55
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (51828bd) 49.50% compared to head (d4e3ef9) 49.50%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ore/include/Acts/Propagator/MaterialInteractor.hpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
- Coverage   49.50%   49.50%   -0.01%     
==========================================
  Files         475      475              
  Lines       26975    26973       -2     
  Branches    12454    12453       -1     
==========================================
- Hits        13355    13353       -2     
  Misses       4762     4762              
  Partials     8858     8858              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andiwand
andiwand previously approved these changes Nov 27, 2023
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

@benjaminhuth benjaminhuth marked this pull request as ready for review November 27, 2023 19:41
@kodiakhq kodiakhq bot merged commit 243850f into acts-project:main Nov 27, 2023
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants