Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undocumented parameters #2702

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

asalzburger
Copy link
Contributor

This PR fixes the doc build, 2 PRs sneaked parameters in.

@github-actions github-actions bot added Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Vertexing labels Nov 20, 2023
@asalzburger asalzburger added this to the next milestone Nov 20, 2023
@asalzburger
Copy link
Contributor Author

Hey @felix-russo - 3/4 are yours, so I thought: I fix, you review

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (1d8d3ec) 49.56% compared to head (fe3331e) 49.56%.
Report is 1 commits behind head on main.

Files Patch % Lines
...ore/include/Acts/Propagator/MaterialInteractor.hpp 47.16% 10 Missing and 18 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2702      +/-   ##
==========================================
- Coverage   49.56%   49.56%   -0.01%     
==========================================
  Files         474      474              
  Lines       26928    26930       +2     
  Branches    12422    12423       +1     
==========================================
  Hits        13348    13348              
+ Misses       4751     4748       -3     
- Partials     8829     8834       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger merged commit c8b27e4 into acts-project:main Nov 21, 2023
@asalzburger asalzburger deleted the doc-fix-undocumented branch November 21, 2023 03:42
@acts-project-service
Copy link
Collaborator

@paulgessinger paulgessinger modified the milestones: next, v31.1.0 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Plugins Affects one or more Plugins Vertexing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants