-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using ParameterSet in SingleFreeTrackParameters #268
Using ParameterSet in SingleFreeTrackParameters #268
Conversation
Codecov Report
@@ Coverage Diff @@
## master #268 +/- ##
==========================================
+ Coverage 44.84% 48.41% +3.56%
==========================================
Files 376 319 -57
Lines 18866 16336 -2530
Branches 8970 7570 -1400
==========================================
- Hits 8461 7909 -552
+ Misses 4905 3175 -1730
+ Partials 5500 5252 -248
Continue to review full report at Codecov.
|
c5f9f5e
to
f3c5105
Compare
b2c5617
to
129ab11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward changes. Looks good to me. The two comments only request minor changes to confirm to our naming guidelines.
62056ff
to
5c8b216
Compare
Replaces the plain storage of data by the ParameterSet as performed in SingleTrackParameters. It is a component of acts-project#165.
This PR replaces the plain storage of data by the
ParameterSet
as performed inSingleTrackParameters
.It is a component of #165.