Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ParameterSet in SingleFreeTrackParameters #268

Conversation

FabianKlimpel
Copy link
Contributor

@FabianKlimpel FabianKlimpel commented Jun 18, 2020

This PR replaces the plain storage of data by the ParameterSet as performed in SingleTrackParameters.
It is a component of #165.

@FabianKlimpel FabianKlimpel self-assigned this Jun 18, 2020
@FabianKlimpel FabianKlimpel added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature and removed Triage labels Jun 18, 2020
@FabianKlimpel FabianKlimpel added this to the v0.25.02 milestone Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #268 into master will increase coverage by 3.56%.
The diff coverage is 44.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   44.84%   48.41%   +3.56%     
==========================================
  Files         376      319      -57     
  Lines       18866    16336    -2530     
  Branches     8970     7570    -1400     
==========================================
- Hits         8461     7909     -552     
+ Misses       4905     3175    -1730     
+ Partials     5500     5252     -248     
Impacted Files Coverage Δ
...Acts/EventData/detail/initialize_parameter_set.hpp 81.81% <ø> (ø)
...include/Acts/TrackFinder/CKFSourceLinkSelector.hpp 47.82% <ø> (ø)
Core/include/Acts/Utilities/Helpers.hpp 58.90% <ø> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.ipp 44.59% <0.00%> (ø)
Core/src/Geometry/CutoutCylinderVolumeBounds.cpp 40.29% <0.00%> (ø)
...lude/Acts/Visualization/EventDataVisualization.hpp 41.00% <30.00%> (-1.47%) ⬇️
Core/src/Visualization/GeometryVisualization.cpp 34.51% <34.51%> (ø)
Core/src/Geometry/ProtoLayerHelper.cpp 48.71% <36.36%> (-14.44%) ⬇️
Core/include/Acts/EventData/ParameterSet.hpp 91.17% <88.88%> (ø)
Core/include/Acts/EventData/Measurement.hpp 63.82% <100.00%> (-2.18%) ⬇️
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2846181...96be12b. Read the comment docs.

@FabianKlimpel FabianKlimpel force-pushed the SingleFreeTrackParametersWithParameterSet branch 4 times, most recently from c5f9f5e to f3c5105 Compare June 23, 2020 11:59
@msmk0 msmk0 modified the milestones: v0.25.02, v0.27.00 Jun 23, 2020
@msmk0 msmk0 self-requested a review June 23, 2020 15:08
@FabianKlimpel FabianKlimpel force-pushed the SingleFreeTrackParametersWithParameterSet branch 2 times, most recently from b2c5617 to 129ab11 Compare June 25, 2020 07:13
@paulgessinger paulgessinger modified the milestones: v0.27.00, v0.28.00 Jun 25, 2020
Copy link
Contributor

@msmk0 msmk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward changes. Looks good to me. The two comments only request minor changes to confirm to our naming guidelines.

@FabianKlimpel FabianKlimpel force-pushed the SingleFreeTrackParametersWithParameterSet branch from 62056ff to 5c8b216 Compare June 25, 2020 12:39
@FabianKlimpel FabianKlimpel requested a review from msmk0 June 25, 2020 13:57
@msmk0 msmk0 merged commit 1c56f72 into acts-project:master Jun 26, 2020
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Jul 13, 2020
Replaces the plain storage of data by the ParameterSet as performed in SingleTrackParameters. It is a component of acts-project#165.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants