Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GSF early stopping now should really stop #2660

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Nov 13, 2023

Now really stop early (before this did not stop propagation). This now adds an extra aborter. Would be good to refactor the propagation at some point to allow easy stopping in actors...

@benjaminhuth benjaminhuth added this to the next milestone Nov 13, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Documentation Affects the documentation Track Fitting labels Nov 13, 2023
@benjaminhuth benjaminhuth added 🛑 blocked This item is blocked by another item and removed Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Documentation Affects the documentation Track Fitting labels Nov 13, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Examples Affects the Examples module Component - Documentation Affects the documentation Track Fitting labels Nov 13, 2023
@benjaminhuth benjaminhuth added 🛑 blocked This item is blocked by another item and removed 🛑 blocked This item is blocked by another item labels Nov 14, 2023
@benjaminhuth benjaminhuth removed the 🛑 blocked This item is blocked by another item label Nov 14, 2023
@github-actions github-actions bot removed Component - Examples Affects the Examples module Component - Documentation Affects the documentation labels Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e8cd68) 49.71% compared to head (5ae7073) 49.72%.

Files Patch % Lines
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2660      +/-   ##
==========================================
+ Coverage   49.71%   49.72%   +0.01%     
==========================================
  Files         474      474              
  Lines       26859    26863       +4     
  Branches    12362    12363       +1     
==========================================
+ Hits        13352    13357       +5     
+ Misses       4706     4704       -2     
- Partials     8801     8802       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asalzburger asalzburger merged commit c016981 into acts-project:main Nov 14, 2023
@benjaminhuth benjaminhuth deleted the fix/gsf-early-stopping branch November 14, 2023 09:33
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Nov 14, 2023
@asalzburger
Copy link
Contributor

I saw not that the Athena tests fail, but I suppose that's expected?

@paulgessinger paulgessinger modified the milestones: next, v31.0.0 Nov 15, 2023
@paulgessinger paulgessinger removed the Fails Athena tests This PR causes a failure in the Athena tests label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Track Fitting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants