Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CCVB outer disk boundary sized (backport of #261) #264

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix CCVB outer disk boundary sized (backport of #261) #264

merged 1 commit into from
Jun 17, 2020

Conversation

paulgessinger
Copy link
Member

Previously, this was rMin -> rMax for the inner disks, and rMed -> rMax
for the outer disks. This has been changed to rMin -> rMed and rMin ->
rMax, respectively.

@paulgessinger
Fix CCVB outer disk boundary sized (acts-project#261)
f2f368a 
Previously, this was rMin -> rMax for the inner disks, and rMed -> rMax
for the outer disks. This has been changed to rMin -> rMed and rMin ->
rMax, respectively.
@paulgessinger paulgessinger added the Bug Something isn't working label Jun 17, 2020
@paulgessinger paulgessinger added this to the v0.25.02 milestone Jun 17, 2020
asalzburger
asalzburger approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@asalzburger asalzburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved for master, so back port will go in as well.

@asalzburger asalzburger merged commit 9cb1082 into acts-project:release/v0.25.X Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalzburger asalzburger asalzburger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
v0.25.02
Development

Successfully merging this pull request may close these issues.
2 participants
@paulgessinger @asalzburger