Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Restructure and update the documentation - 2023 edition #2610

Merged
merged 29 commits into from
Nov 7, 2023

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented Nov 1, 2023

This PR rationalizes the documentation a bit. The main points are

  • Remove the documentation of the old standalone examples executables

  • Restructure the core documentation to be less sprawling

  • Move the figures from a central folder closer to the relevant source files

  • Remove the full auto API documentation in favor of a combination of hard-coded documented symbols + an auto detection mechanism to catch when we references symbols somewhere

    • This reduces the time it takes to build the docs drastically
  • Enable nitpicky generation, which will warn (and fail) if symbols are references that don't have a target.

  • Try to auto-generate API listings only for the elements we explicitly call out by class / func roles.

Blocked by:

@paulgessinger paulgessinger added this to the next milestone Nov 1, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Component - Documentation Affects the documentation labels Nov 1, 2023
@github-actions github-actions bot added the Infrastructure Changes to build tools, continous integration, ... label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2610 (bdd1475) into main (7529e62) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   49.59%   49.59%           
=======================================
  Files         473      473           
  Lines       26824    26824           
  Branches    12355    12355           
=======================================
  Hits        13304    13304           
  Misses       4753     4753           
  Partials     8767     8767           
Files Coverage Δ
Core/include/Acts/Propagator/AbortList.hpp 83.33% <ø> (ø)
Core/include/Acts/Propagator/ActionList.hpp 100.00% <ø> (ø)
Core/include/Acts/Propagator/ConstrainedStep.hpp 68.88% <ø> (ø)
Core/include/Acts/Surfaces/ConeBounds.hpp 71.42% <ø> (ø)
Core/include/Acts/Surfaces/CylinderBounds.hpp 68.75% <ø> (ø)
Core/include/Acts/Surfaces/CylinderSurface.hpp 100.00% <ø> (ø)
Core/include/Acts/Surfaces/DiamondBounds.hpp 62.50% <ø> (ø)
Core/include/Acts/Surfaces/DiscSurface.hpp 100.00% <ø> (ø)
Core/include/Acts/Surfaces/EllipseBounds.hpp 62.96% <ø> (ø)
Core/include/Acts/Surfaces/LineSurface.hpp 100.00% <ø> (ø)
... and 5 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@paulgessinger paulgessinger added the 🛑 blocked This item is blocked by another item label Nov 3, 2023
@paulgessinger paulgessinger removed the 🛑 blocked This item is blocked by another item label Nov 6, 2023
@paulgessinger paulgessinger marked this pull request as ready for review November 6, 2023 07:11
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could mention in the description, that you removed some of the examples.

docs/requirements.in Outdated Show resolved Hide resolved
docs/core/eventdata.md Outdated Show resolved Hide resolved
docs/examples/howto/howto.md Show resolved Hide resolved
docs/core/material.md Outdated Show resolved Hide resolved
AJPfleger
AJPfleger previously approved these changes Nov 6, 2023
@acts-policybot acts-policybot bot dismissed AJPfleger’s stale review November 6, 2023 14:47

Invalidated by push of 23787a6

@paulgessinger
Copy link
Member Author

@AJPfleger can you click the button again? I've updated this after #2591 was merged.

paulgessinger added a commit to paulgessinger/acts that referenced this pull request Nov 6, 2023
Also changes the execution of the lazy auto api generation to
only run on demand (on in the CI and RTD)

Blocked by:

- acts-project#2610
@kodiakhq kodiakhq bot merged commit 922e6d1 into acts-project:main Nov 7, 2023
@github-actions github-actions bot removed the automerge label Nov 7, 2023
paulgessinger added a commit to paulgessinger/acts that referenced this pull request Nov 7, 2023
Also changes the execution of the lazy auto api generation to
only run on demand (on in the CI and RTD)

Blocked by:

- acts-project#2610
kodiakhq bot pushed a commit that referenced this pull request Nov 14, 2023
Also changes the execution of the lazy auto api generation to only run on demand (in the CI and RTD)

Blocked by:
- #2610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Core Affects the Core module Component - Documentation Affects the documentation Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants