Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add measurement map selector with geometry selection #2572

Merged

Conversation

benjaminhuth
Copy link
Member

Allows to create a subset of a particles-measurement-map with a geometry selection.

@benjaminhuth benjaminhuth added this to the next milestone Oct 23, 2023
@github-actions github-actions bot added the Component - Examples Affects the Examples module label Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2572 (69772c6) into main (db3ec38) will not change coverage.
The diff coverage is n/a.

❗ Current head 69772c6 differs from pull request most recent head a253d42. Consider uploading reports for the commit a253d42 to get more accurate results

@@           Coverage Diff           @@
##             main    #2572   +/-   ##
=======================================
  Coverage   49.64%   49.64%           
=======================================
  Files         471      471           
  Lines       26632    26632           
  Branches    12237    12237           
=======================================
  Hits        13222    13222           
  Misses       4742     4742           
  Partials     8668     8668           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Oct 23, 2023
@andiwand
Copy link
Contributor

I wonder if such a algorithm is easy enough to be implemented in python. but not sure how efficient that would be and if we have all the necessary bindings. just a thought

paulgessinger
paulgessinger previously approved these changes Oct 23, 2023
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@benjaminhuth
Copy link
Member Author

I wonder if such a algorithm is easy enough to be implemented in python. but not sure how efficient that would be and if we have all the necessary bindings. just a thought

I wonder if it is really worth to deal with all these things like binding the whiteboard and the EDM etc...
But in principle it would be nice to have some more flexibility on manipulating the EDM in python...

@benjaminhuth benjaminhuth dismissed stale reviews from paulgessinger and andiwand via a253d42 October 23, 2023 20:54
…easurementMapSelector.hpp

Co-authored-by: Paul Gessinger <[email protected]>
@kodiakhq kodiakhq bot merged commit adccec3 into acts-project:main Oct 24, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 24, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants