Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add (optional) Jacobian reversal to Track #2571

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

paulgessinger
Copy link
Member

TrackProxy::reverseTrackStates can now optionally invert its jacobians, and move them to the correct corresponding track state.

`TrackProxy::reverseTrackStates` can now optionally invert its
jacobians, and move them to the correct corresponding track state.
@paulgessinger paulgessinger added this to the next milestone Oct 23, 2023
@github-actions github-actions bot added Component - Core Affects the Core module Event Data Model labels Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #2571 (9b7e3f0) into main (630fc20) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #2571      +/-   ##
==========================================
- Coverage   49.64%   49.63%   -0.02%     
==========================================
  Files         471      471              
  Lines       26632    26640       +8     
  Branches    12237    12247      +10     
==========================================
  Hits        13222    13222              
  Misses       4742     4742              
- Partials     8668     8676       +8     
Files Coverage Δ
Core/src/Geometry/TrackingVolume.cpp 47.64% <100.00%> (ø)
Core/include/Acts/EventData/TrackProxy.hpp 74.60% <33.33%> (-3.30%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Oct 23, 2023
@paulgessinger paulgessinger marked this pull request as ready for review October 23, 2023 19:26
@paulgessinger
Copy link
Member Author

Compiler segfaults again, maybe due to zip and track state ranges?

Core/include/Acts/EventData/TrackProxy.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Outdated Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Show resolved Hide resolved
Core/include/Acts/EventData/TrackProxy.hpp Outdated Show resolved Hide resolved
Tests/UnitTests/Core/EventData/TrackTests.cpp Outdated Show resolved Hide resolved
@paulgessinger
Copy link
Member Author

All changed @felix-russo.

Copy link
Contributor

@felix-russo felix-russo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my side (except if you want to add some documentation about the last/first Jacobian that you set to 0)

@kodiakhq kodiakhq bot merged commit 6df0704 into acts-project:main Oct 25, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants