-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow particle selection with measurment count #2570
Merged
kodiakhq
merged 6 commits into
acts-project:main
from
benjaminhuth:feature/improve-particle-selector
Oct 24, 2023
Merged
feat: Allow particle selection with measurment count #2570
kodiakhq
merged 6 commits into
acts-project:main
from
benjaminhuth:feature/improve-particle-selector
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
reviewed
Oct 23, 2023
Co-authored-by: Andreas Stefl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2570 +/- ##
=======================================
Coverage 49.64% 49.64%
=======================================
Files 471 471
Lines 26632 26632
Branches 12237 12237
=======================================
Hits 13222 13222
Misses 4742 4742
Partials 8668 8668 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
previously approved these changes
Oct 23, 2023
andiwand
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the particle selector to allow to select particles based on the number of measurements. The measurement related inputs are only required if the number of measurements is actually constrained.