Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add infrastructure for GNN+CKF #2558

Conversation

benjaminhuth
Copy link
Member

This adds two algorithms:

  • PrototracksToParsAndSeeds: This is needed, to get a consistent set of prototracks and parameters. With two seperate algorithms, failed parameter cannot be applied onto the prototrack collection
  • TrackFindinigFromPrototracks: This allows to start the CKF from prototracks, and only allows measurments from the prototrack on the corresponding surfaces.

@benjaminhuth benjaminhuth added this to the next milestone Oct 19, 2023
@benjaminhuth benjaminhuth requested a review from andiwand October 19, 2023 09:39
@github-actions github-actions bot added Component - Examples Affects the Examples module Track Finding labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2558 (e581beb) into main (244b280) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   49.76%   49.76%           
=======================================
  Files         466      466           
  Lines       26353    26353           
  Branches    12100    12100           
=======================================
  Hits        13114    13114           
  Misses       4632     4632           
  Partials     8607     8607           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

andiwand
andiwand previously approved these changes Oct 19, 2023
@benjaminhuth benjaminhuth requested a review from andiwand October 19, 2023 18:44
@kodiakhq kodiakhq bot merged commit fa932cf into acts-project:main Oct 20, 2023
@acts-project-service acts-project-service added the Fails Athena tests This PR causes a failure in the Athena tests label Oct 20, 2023
@paulgessinger paulgessinger modified the milestones: next, v30.3.0 Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Examples Affects the Examples module Fails Athena tests This PR causes a failure in the Athena tests Track Finding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants