-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add infrastructure for GNN+CKF #2558
Merged
kodiakhq
merged 9 commits into
acts-project:main
from
benjaminhuth:feature/track-finding-from-prototrack-algorithms
Oct 20, 2023
Merged
feat: Add infrastructure for GNN+CKF #2558
kodiakhq
merged 9 commits into
acts-project:main
from
benjaminhuth:feature/track-finding-from-prototrack-algorithms
Oct 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2558 +/- ##
=======================================
Coverage 49.76% 49.76%
=======================================
Files 466 466
Lines 26353 26353
Branches 12100 12100
=======================================
Hits 13114 13114
Misses 4632 4632
Partials 8607 8607 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
reviewed
Oct 19, 2023
...s/TrackFindingExaTrkX/include/ActsExamples/TrackFindingExaTrkX/PrototracksToParsAndSeeds.hpp
Outdated
Show resolved
Hide resolved
...s/TrackFindingExaTrkX/include/ActsExamples/TrackFindingExaTrkX/PrototracksToParsAndSeeds.hpp
Outdated
Show resolved
Hide resolved
Examples/Algorithms/TrackFindingExaTrkX/src/PrototracksToParsAndSeeds.cpp
Outdated
Show resolved
Hide resolved
...dingExaTrkX/include/ActsExamples/TrackFindingExaTrkX/TrackFindingFromPrototrackAlgorithm.hpp
Show resolved
Hide resolved
...s/TrackFindingExaTrkX/include/ActsExamples/TrackFindingExaTrkX/PrototracksToParsAndSeeds.hpp
Outdated
Show resolved
Hide resolved
andiwand
previously approved these changes
Oct 19, 2023
andiwand
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component - Examples
Affects the Examples module
Fails Athena tests
This PR causes a failure in the Athena tests
Track Finding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two algorithms:
PrototracksToParsAndSeeds
: This is needed, to get a consistent set ofprototracks
andparameters
. With two seperate algorithms, failedparameter
cannot be applied onto theprototrack
collectionTrackFindinigFromPrototracks
: This allows to start the CKF from prototracks, and only allows measurments from the prototrack on the corresponding surfaces.